LGTM (with two comments to address).
https://codereview.chromium.org/19723004/diff/2001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/19723004/diff/2001/src/hydrogen-instructions.cc#newcode3241
src/hydrogen-instructions.cc:3241:
dominator_allocate_instr->SetFlags(HAllocate::PREFILL_WITH_FILLER);
I like this! Now the hydrogen graph stays the same, no matter whether
the heap verifier is running or not.
https://codereview.chromium.org/19723004/diff/2001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/19723004/diff/2001/src/ia32/lithium-codegen-ia32.cc#newcode6066
src/ia32/lithium-codegen-ia32.cc:6066: __ mov(MemOperand(result, temp,
times_pointer_size, -1),
Better use FieldOperand here instead of the MemOperand with a magic -1
value.
https://codereview.chromium.org/19723004/diff/2001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/19723004/diff/2001/src/x64/lithium-codegen-x64.cc#newcode5095
src/x64/lithium-codegen-x64.cc:5095: __ Move(MemOperand(result, temp,
times_pointer_size, -1),
Better use FieldOperand here instead of the MemOperand with a magic -1
value.
https://codereview.chromium.org/19723004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
