Got some comments. It would be great if you could audit all the uses of
*_STRING_TYPE instance types.
https://codereview.chromium.org/19514004/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/19514004/diff/1/src/arm/macro-assembler-arm.cc#newcode3269
src/arm/macro-assembler-arm.cc:3269: const int kFlatAsciiStringTag =
ASCII_INTERNALIZED_STRING_TYPE;
I actually prefer not to use the defined instance type, but instead
something corresponding to the mask:
kStringTag | kOneByteStringTag | kSeqStringTag
https://codereview.chromium.org/19514004/diff/1/src/arm/macro-assembler-arm.cc#newcode3284
src/arm/macro-assembler-arm.cc:3284: int kFlatAsciiStringTag =
ASCII_STRING_TYPE;
I believe this suffers from the same issue!
https://codereview.chromium.org/19514004/diff/1/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/19514004/diff/1/src/x64/macro-assembler-x64.cc#newcode2286
src/x64/macro-assembler-x64.cc:2286: cmpl(scratch, Immediate(kStringTag
| kSeqStringTag | kOneByteStringTag));
I like it this way. Less error prone apparently.
https://codereview.chromium.org/19514004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
