Hi Yang, thanks for the push to look harder. The audit found another issue
in
full-codegen-ia32.cc. And it's good policy to build from elemental tags when
building custom masks.
Thanks,
--Michael
https://codereview.chromium.org/19514004/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/19514004/diff/1/src/arm/macro-assembler-arm.cc#newcode3269
src/arm/macro-assembler-arm.cc:3269: const int kFlatAsciiStringTag =
ASCII_INTERNALIZED_STRING_TYPE;
On 2013/07/22 09:09:46, Yang wrote:
I actually prefer not to use the defined instance type, but instead
something
corresponding to the mask:
kStringTag | kOneByteStringTag | kSeqStringTag
Done.
https://codereview.chromium.org/19514004/diff/1/src/arm/macro-assembler-arm.cc#newcode3284
src/arm/macro-assembler-arm.cc:3284: int kFlatAsciiStringTag =
ASCII_STRING_TYPE;
On 2013/07/22 09:09:46, Yang wrote:
I believe this suffers from the same issue!
Grr. Removed defined instance check here too, thanks.
https://codereview.chromium.org/19514004/diff/1/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/19514004/diff/1/src/x64/macro-assembler-x64.cc#newcode2286
src/x64/macro-assembler-x64.cc:2286: cmpl(scratch, Immediate(kStringTag
| kSeqStringTag | kOneByteStringTag));
On 2013/07/22 09:09:46, Yang wrote:
I like it this way. Less error prone apparently.
Indeed, way better. thx.
https://codereview.chromium.org/19514004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
