https://codereview.chromium.org/19916002/diff/2001/src/log.cc
File src/log.cc (left):

https://codereview.chromium.org/19916002/diff/2001/src/log.cc#oldcode1271
src/log.cc:1271: if (!is_logging_code_events()) return;
On 2013/07/22 09:31:42, loislo wrote:
We already have this check in the macro LOG_CODE_EVENT,
so current implementation does this check twice.

I disagree, now all these calls will be executed if
cpu_profiler()->is_profiling() == true no matter what
is_logging_code_events() state is.

https://codereview.chromium.org/19916002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to