LGTM with a nit
https://codereview.chromium.org/19916002/diff/13001/src/log.cc
File src/log.cc (right):
https://codereview.chromium.org/19916002/diff/13001/src/log.cc#newcode57
src/log.cc:57: #define PROFILER_LOG(Call)
\
This macro is unsafe because of 2 reasons (well, actually more :-):
* It contains a sequence of instructions, not a single one.
* It has an unbalanced "if".
Although it doesn't matter at the current call sites, I would prefer a
"do { ... } while(false)" wrapper around it, just to be sure.
https://codereview.chromium.org/19916002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
