https://codereview.chromium.org/19798002/diff/16001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/19798002/diff/16001/src/hydrogen-instructions.h#newcode3362
src/hydrogen-instructions.h:3362: HConstant* CopyToTruncatedNumber(Zone*
zone);
This sounds more generic than it is. How about "CopyOddballToNumber"?
https://codereview.chromium.org/19798002/diff/16001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/19798002/diff/16001/src/hydrogen.cc#newcode7857
src/hydrogen.cc:7857: Push(Add<HConstant>(OS::nan_value(),
Representation::Double()));
Stack height mismatches at basic block joins are a pattern that we need
to eliminate/avoid. Suggestion:
HValue copied_constant = Add<HConstant>(...);
IfBuilder if_nan(this);
if_nan.If<...>(...);
if_nan.Then();
if_nan.ElseDeopt();
if_nan.End();
return copied_constant;
https://codereview.chromium.org/19798002/diff/16001/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/19798002/diff/16001/src/hydrogen.h#newcode1121
src/hydrogen.h:1121: void BuildHydrogenBinaryOperation(BinaryOperation*
expr);
I don't see this defined or used anywhere.
https://codereview.chromium.org/19798002/diff/16001/src/hydrogen.h#newcode1123
src/hydrogen.h:1123: HValue* ConstantToNumber(HValue* value);
I don't see this anywhere either.
https://codereview.chromium.org/19798002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
