Danno, thanks a lot for your review.
I choose the name StackOperandForArgument as either the "rsp + disp"
or "rsp +
index * scale + disp" in this CL are used to access argument. Receiver is
considered as argument 0. For non-argument access, I used kPCOnStackSize
instead
of kPointerSize and explained them in the place.
I will use StackOperandForPc to address the return address access in
another CL.
https://codereview.chromium.org/19857006/diff/23001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):
https://codereview.chromium.org/19857006/diff/23001/src/x64/builtins-x64.cc#newcode711
src/x64/builtins-x64.cc:711:
Use kPCOnStackSize instead of kPointerSize.
https://codereview.chromium.org/19857006/diff/23001/src/x64/builtins-x64.cc#newcode720
src/x64/builtins-x64.cc:720:
Use kPCOnStackSize instead of kPointerSize.
https://codereview.chromium.org/19857006/diff/23001/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
https://codereview.chromium.org/19857006/diff/23001/src/x64/stub-cache-x64.cc#newcode1077
src/x64/stub-cache-x64.cc:1077:
Use kPCOnStackSize instead of kPointerSize.
https://codereview.chromium.org/19857006/diff/23001/src/x64/stub-cache-x64.cc#newcode1137
src/x64/stub-cache-x64.cc:1137:
Use kPCOnStackSize instead of kPointerSize.
https://codereview.chromium.org/19857006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
