Revision: 15909
Author: [email protected]
Date: Fri Jul 26 06:18:56 2013
Log: Remove --prof-auto flag
There is already --prof-lazy flag which should be enough.
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/20482003
http://code.google.com/p/v8/source/detail?r=15909
Modified:
/branches/bleeding_edge/src/flag-definitions.h
/branches/bleeding_edge/src/log-utils.cc
/branches/bleeding_edge/src/log.cc
/branches/bleeding_edge/test/cctest/test-log.cc
=======================================
--- /branches/bleeding_edge/src/flag-definitions.h Thu Jul 25 07:11:53 2013
+++ /branches/bleeding_edge/src/flag-definitions.h Fri Jul 26 06:18:56 2013
@@ -744,11 +744,9 @@
DEFINE_bool(log_suspect, false, "Log suspect operations.")
DEFINE_bool(prof, false,
"Log statistical profiling information (implies --log-code).")
-DEFINE_bool(prof_auto, true,
- "Used with --prof, starts profiling automatically")
DEFINE_bool(prof_lazy, false,
"Used with --prof, only does sampling and logging"
- " when profiler is active (implies --noprof_auto).")
+ " when profiler is active.")
DEFINE_bool(prof_browser_mode, true,
"Used with --prof, turns on browser-compatible mode for
profiling.")
DEFINE_bool(log_regexp, false, "Log regular expression execution.")
=======================================
--- /branches/bleeding_edge/src/log-utils.cc Thu Jul 18 10:19:31 2013
+++ /branches/bleeding_edge/src/log-utils.cc Fri Jul 26 06:18:56 2013
@@ -66,10 +66,9 @@
// --prof implies --log-code.
if (FLAG_prof) FLAG_log_code = true;
- // --prof_lazy controls --log-code, implies --noprof_auto.
+ // --prof_lazy controls --log-code.
if (FLAG_prof_lazy) {
FLAG_log_code = false;
- FLAG_prof_auto = false;
}
// If we're logging anything, we need to open the log file.
=======================================
--- /branches/bleeding_edge/src/log.cc Tue Jul 23 01:12:15 2013
+++ /branches/bleeding_edge/src/log.cc Fri Jul 26 06:18:56 2013
@@ -1998,10 +1998,9 @@
FLAG_log_snapshot_positions = true;
}
- // --prof_lazy controls --log-code, implies --noprof_auto.
+ // --prof_lazy controls --log-code.
if (FLAG_prof_lazy) {
FLAG_log_code = false;
- FLAG_prof_auto = false;
}
SmartArrayPointer<const char> log_file_name =
@@ -2020,12 +2019,10 @@
if (FLAG_prof) {
profiler_ = new Profiler(isolate);
- if (!FLAG_prof_auto) {
+ if (FLAG_prof_lazy) {
profiler_->pause();
} else {
logging_nesting_ = 1;
- }
- if (!FLAG_prof_lazy) {
profiler_->Engage();
}
}
=======================================
--- /branches/bleeding_edge/test/cctest/test-log.cc Tue Jul 23 06:44:15 2013
+++ /branches/bleeding_edge/test/cctest/test-log.cc Fri Jul 26 06:18:56 2013
@@ -60,7 +60,6 @@
: saved_log_(i::FLAG_log),
saved_prof_lazy_(i::FLAG_prof_lazy),
saved_prof_(i::FLAG_prof),
- saved_prof_auto_(i::FLAG_prof_auto),
temp_file_(NULL),
// Need to run this prior to creating the scope.
trick_to_run_init_flags_(init_flags_(prof_lazy)),
@@ -76,7 +75,6 @@
if (temp_file_ != NULL) fclose(temp_file_);
i::FLAG_prof_lazy = saved_prof_lazy_;
i::FLAG_prof = saved_prof_;
- i::FLAG_prof_auto = saved_prof_auto_;
i::FLAG_log = saved_log_;
}
@@ -97,7 +95,6 @@
i::FLAG_log = true;
i::FLAG_prof = true;
i::FLAG_prof_lazy = prof_lazy;
- i::FLAG_prof_auto = false;
i::FLAG_logfile = i::Log::kLogToTemporaryFile;
return prof_lazy;
}
@@ -105,7 +102,6 @@
const bool saved_log_;
const bool saved_prof_lazy_;
const bool saved_prof_;
- const bool saved_prof_auto_;
FILE* temp_file_;
const bool trick_to_run_init_flags_;
v8::HandleScope scope_;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
