lgtm
https://chromiumcodereview.appspot.com/20323002/diff/2001/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://chromiumcodereview.appspot.com/20323002/diff/2001/src/ia32/lithium-ia32.cc#newcode788
src/ia32/lithium-ia32.cc:788: // Left shifts can deoptimize if we shift
by > 0 and the result cannot be
What if instr representation is smi but right_value isn't a constant,
could we deopt in that case? Do we need an environment then?
https://chromiumcodereview.appspot.com/20323002/diff/2001/src/ia32/lithium-ia32.cc#newcode802
src/ia32/lithium-ia32.cc:802: // Shift operations can only deoptimize if
we do a logical shift by 0 and
Say "Right shift operations" here.
https://chromiumcodereview.appspot.com/20323002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
