https://codereview.chromium.org/21089006/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/21089006/diff/1/src/hydrogen-instructions.h#newcode5281
src/hydrogen-instructions.h:5281: static Flags SetAllocationFlag(Flags
flags, Flags allocation_flag) {
As discussed offline: I don't like this helper very much, it just has
minor advantages over manipulating the flags field by hand. IMHO the
DefaultFlags() helper could instead take a PretenureFlag and already
return the correct flags. This works everywhere expect for FastLiteral,
for which we have other plans anyways.
https://codereview.chromium.org/21089006/diff/1/src/hydrogen-instructions.h#newcode5347
src/hydrogen-instructions.h:5347: static const int kAllocationFlagsMask
= 0x7;
Better compute this using the above three enum values, otherwise it
might become out of sync.
https://codereview.chromium.org/21089006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
