DBC.
Could you explain briefly what the motivation for this change is?
https://codereview.chromium.org/20843012/diff/6001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/20843012/diff/6001/src/compiler.cc#newcode488
src/compiler.cc:488: info()->set_bailout_reason(kCodeGenerationFailed);
While you're here, please wrap this into an "if
(info()->bailout_reason() != kNoReason) {...}" check (otherwise it
overwrites the more detailed reason that the Lithium code generator
might have set).
https://codereview.chromium.org/20843012/diff/6001/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):
https://codereview.chromium.org/20843012/diff/6001/src/ia32/stub-cache-ia32.cc#newcode3156
src/ia32/stub-cache-ia32.cc:3156: __ Check(not_equal,
kDontDeleteCellsCanTContainTheHole);
nit: s/CanT/Cannot/
https://codereview.chromium.org/20843012/diff/6001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/20843012/diff/6001/src/objects.cc#newcode15970
src/objects.cc:15970: static const char* error_messages_[] =
{ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)};
nit: 80col
https://codereview.chromium.org/20843012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
