On 2013/08/09 14:02:29, Jakob wrote:
On 2013/08/02 09:54:51, loislo wrote:
> On 2013/08/02 08:13:46, Jakob wrote:
> > LGTM with one more comment.
> >
> > https://codereview.chromium.org/20843012/diff/16001/src/compiler.cc
> > File src/compiler.cc (right):
> >
> >
https://codereview.chromium.org/20843012/diff/16001/src/compiler.cc#newcode488
> > src/compiler.cc:488: if (info()->bailout_reason() != kNoReason) {
> > Sorry, I mixed up the condition in my earlier comment. Obviously this
should
> be
> > "==" -- only set the reason if it's not set yet.
>
> done
I think you forgot to commit this change or something. bleeding_edge still
says:
if (info()->bailout_reason() != kNoReason) {
info()->set_bailout_reason(kCodeGenerationFailed);
}
which is bogus.
Fix is up for review: https://codereview.chromium.org/22404007/
https://codereview.chromium.org/20843012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
