Thanks for the patch, this is close. I like the direction it's going.
Just one more bigger thing, otherwise just nits:
In the case that you have argc, I think it might make sense to have a
version of
StackOperandForArgument that isn't reversed, e.g. :
StackOperandForArgument(0, argc) would return the first argument.
You won't use this version when the offset is a constant, but whenever it's
already computed from argc, I think it makes it clearer.
https://codereview.chromium.org/21123008/diff/15001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/21123008/diff/15001/src/x64/code-stubs-x64.cc#newcode4223
src/x64/code-stubs-x64.cc:4223: int extra_argument_offset =
extra_stack_space / kPointerSize;
Just make this
int extra_argument_offset = HasCallSiteInlineCheck() ? 1 : 0
and get rid of extra_stack_space
https://codereview.chromium.org/21123008/diff/15001/src/x64/code-stubs-x64.cc#newcode4324
src/x64/code-stubs-x64.cc:4324: __ ret(2 * kPointerSize +
extra_stack_space);
__ ret((extra_argument_offset + 2) * kPointerSize);
https://codereview.chromium.org/21123008/diff/15001/src/x64/code-stubs-x64.cc#newcode4346
src/x64/code-stubs-x64.cc:4346: __ ret(2 * kPointerSize +
extra_stack_space);
__ ret((extra_argument_offset + 2) * kPointerSize);
https://codereview.chromium.org/21123008/diff/15001/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
https://codereview.chromium.org/21123008/diff/15001/src/x64/stub-cache-x64.cc#newcode417
src/x64/stub-cache-x64.cc:417: for (int i = 1; i <=
kFastApiCallArguments; i++) {
Just change the loop to iterate from 0 to < kFastApiCallArguments, then
you can pass "i" instead of "i - 1"
https://codereview.chromium.org/21123008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
