https://codereview.chromium.org/21721002/diff/1/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (right):
https://codereview.chromium.org/21721002/diff/1/src/x64/assembler-x64.h#newcode582
src/x64/assembler-x64.h:582: // The length of call(kScratchRegister).
I am not sure that it is help to include "Scratch" in the name here an
below. Perhaps a little more generic is better, e.g.
kCallRegisterShortInstructionSize = 3;
kCallImmediateShortInstructionSize = 5;
kMoveAddressIntoRegisterShortInstructionSize
etc...
https://codereview.chromium.org/21721002/diff/1/src/x64/assembler-x64.h#newcode585
src/x64/assembler-x64.h:585: static const int
kShortCallInstructionLength = 5;
Unify to either "...Length" or "...Size". I think "Length" is better.
https://codereview.chromium.org/21721002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
