danno, thanks a lot for the review. All comments are addressed. Please take
another look.
https://codereview.chromium.org/21721002/diff/1/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (right):
https://codereview.chromium.org/21721002/diff/1/src/x64/assembler-x64.h#newcode582
src/x64/assembler-x64.h:582: // The length of call(kScratchRegister).
If the register number is less than 8, then the call instruction size is
2. For move instruction, it is true for 64-bit system for REX.W, but for
x32, if the register number is less than 8, we do not need the REX
prefix.
kShortCallInstruction is better as it is short indeed. It only could
access [-2G, 2G] relative to the current pc address.
https://codereview.chromium.org/21721002/diff/1/src/x64/assembler-x64.h#newcode585
src/x64/assembler-x64.h:585: static const int
kShortCallInstructionLength = 5;
On 2013/08/02 14:01:20, danno wrote:
Unify to either "...Length" or "...Size". I think "Length" is better.
Done.
https://codereview.chromium.org/21721002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
