https://codereview.chromium.org/22378003/diff/15001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/22378003/diff/15001/src/hydrogen-instructions.cc#newcode3339
src/hydrogen-instructions.cc:3339:
This method is getting pretty big; suggest pulling out the bodies of
various if's into their own helper methods. Also a helper to create an
int32 constant and insert it after a particular instruction would
probably help clean this up a lot.
https://codereview.chromium.org/22378003/diff/15001/src/hydrogen-instructions.cc#newcode3394
src/hydrogen-instructions.cc:3394:
HConstant::cast(dominator_free_space_size)->GetInteger32Constant();
I think this cast is redundant.
https://codereview.chromium.org/22378003/diff/15001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/22378003/diff/15001/src/hydrogen-instructions.h#newcode5055
src/hydrogen-instructions.h:5055: void
set_dominating_allocate(HAllocate* allocate) {
Don't add setters for fields that should not be modified outside the
class.
https://codereview.chromium.org/22378003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
