https://codereview.chromium.org/22378003/diff/63001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/22378003/diff/63001/src/hydrogen-instructions.cc#newcode3366
src/hydrogen-instructions.cc:3366:
filler_free_space_size_->DeleteAndReplaceWith(new_free_space_size);
On 2013/08/26 09:50:24, titzer wrote:
Whoa. I don't think you want to DeleteAndReplaceWith() here, because
the size is
just an integer constant, and if it is used for more than the
allocation in
question, then you've just updated the other uses of that constant to
point to
the new constant. That would be an ouchie. This probably doesn't
happen now,
because I think you insert a new constant each time, but you shouldn't
assume
this will hold in the future.
Yeah, let's play safe. Done.
https://codereview.chromium.org/22378003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
