Some DBCs...
https://codereview.chromium.org/22347003/diff/3001/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/22347003/diff/3001/include/v8-profiler.h#newcode76
include/v8-profiler.h:76: unsigned GetSelfSamplesCount() const;
Two remarks here:
* Silently changing the signature of an existing API entry is not
really nice, but I guess that the number of clients of the profiling API
is low (i.e. = 1 ;-), so this is OK here. Otherwise I'll redirect
complaints from embedders directly to the CL author... :-D
* Are we really sure that unsigned is future-proof? Wouldn't uint64_t
be better?
https://codereview.chromium.org/22347003/diff/3001/src/api.cc
File src/api.cc (left):
https://codereview.chromium.org/22347003/diff/3001/src/api.cc#oldcode7481
src/api.cc:7481: IsDeadCheck(isolate,
"v8::CpuProfileNode::GetScriptId");
On 2013/08/08 11:04:47, loislo wrote:
why did you remove that lines?
That's OK, the whole idea of IsDeadCheck is fundamentally broken,
anyway, and it's already on death row...
https://codereview.chromium.org/22347003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
