https://codereview.chromium.org/22347003/diff/3001/include/v8-profiler.h
File include/v8-profiler.h (right):
https://codereview.chromium.org/22347003/diff/3001/include/v8-profiler.h#newcode76
include/v8-profiler.h:76: unsigned GetSelfSamplesCount() const;
On 2013/08/08 11:51:57, Sven Panne wrote:
Two remarks here:
* Silently changing the signature of an existing API entry is not
really
nice, but I guess that the number of clients of the profiling API is
low (i.e. =
1 ;-), so this is OK here. Otherwise I'll redirect complaints from
embedders
directly to the CL author... :-D
Ok, let me do this in two steps as I originally intended: first
introduce unsgined GetHitCount and then deprecate this one.
* Are we really sure that unsigned is future-proof? Wouldn't
uint64_t be
better?
Internally it is unsigned anyway. With sampling rate 0.1ms it will be
enough for ~4 000 000 000 / 10 000 = 400 000 / 3600 ~ 100 hours which is
more than enough for a web application where profiling is regularly done
for several minutes. I can change it if you insist but I don't think
there is a need to do this now, also we would have to change return type
of CpuProfile::GetSamplesCount as well.
https://codereview.chromium.org/22347003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
