On 2013/08/13 13:04:20, danno wrote:
https://codereview.chromium.org/22290005/diff/44001/src/ia32/macro-assembler-ia32.cc
File src/ia32/macro-assembler-ia32.cc (right):
https://codereview.chromium.org/22290005/diff/44001/src/ia32/macro-assembler-ia32.cc#newcode281
src/ia32/macro-assembler-ia32.cc:281: XMMRegister temp, bool
bailout_on_minus_zero, Label* bailout) {
perhaps a better name than bailout? lost_precision? and
bailout_on_minus_zero
->
treat_minus_zero_as_zero?
https://codereview.chromium.org/22290005/diff/44001/src/ia32/macro-assembler-ia32.h
File src/ia32/macro-assembler-ia32.h (right):
https://codereview.chromium.org/22290005/diff/44001/src/ia32/macro-assembler-ia32.h#newcode484
src/ia32/macro-assembler-ia32.h:484: void TaggedToI(Register input_reg,
Register
result_reg,
I think it's better to not have this second version at all. Callers
should be
forced to think about whether they are passing a temp register or not.
ptal
https://codereview.chromium.org/22290005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
