I like this change, but there seem to still be issues with it. If missing,
can
you add tests for all the cases that I mentioned that are actually broken?
https://codereview.chromium.org/22290005/diff/80001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/22290005/diff/80001/src/ia32/code-stubs-ia32.cc#newcode2382
src/ia32/code-stubs-ia32.cc:2382: __ TruncateHeapNumberToI(edx, ecx);
I'd prefer to have the target on the left, as we have everywhere else
(eg __ mov(ecx, edx)).
https://codereview.chromium.org/22290005/diff/80001/src/ia32/code-stubs-ia32.cc#newcode2383
src/ia32/code-stubs-ia32.cc:2383: __ mov(edx, ecx);
Why is edx overwritten by ecx here, rather than
TruncateHeapNumberToI(edx, edx);
https://codereview.chromium.org/22290005/diff/80001/src/ia32/code-stubs-ia32.cc#newcode2669
src/ia32/code-stubs-ia32.cc:2669: __ jmp(&int_exponent);
Unconditional jump with unlabeled code below?
https://codereview.chromium.org/22290005/diff/80001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/22290005/diff/80001/src/ia32/lithium-codegen-ia32.cc#newcode5428
src/ia32/lithium-codegen-ia32.cc:5428:
instr->hydrogen()->GetMinusZeroMode(), &bailout, Label::kNear);
This DoDoubleToSmi just seems to do DoubleToI? Missing SmiTag at the
end?
https://codereview.chromium.org/22290005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
