LGTM with comments.
https://codereview.chromium.org/23352004/diff/2001/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/23352004/diff/2001/src/arm/macro-assembler-arm.cc#newcode2852
src/arm/macro-assembler-arm.cc:2852: DebugBreak();
You probably want to use "stop()" instead of "DebugBreak()" here,
because otherwise you are calling into the JavaScript debugger.
https://codereview.chromium.org/23352004/diff/2001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/23352004/diff/2001/src/flag-definitions.h#newcode267
src/flag-definitions.h:267: DEFINE_bool(trap_on_abort, false,
nit: Should fit into one line. Also since this is only effective in
debug mode, it should be moved down into the "Debug only flags" section.
https://codereview.chromium.org/23352004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
