https://chromiumcodereview.appspot.com/23401003/diff/1/include/v8.h
File include/v8.h (left):
https://chromiumcodereview.appspot.com/23401003/diff/1/include/v8.h#oldcode314
include/v8.h:314: #ifndef V8_USE_UNSAFE_HANDLES
Would it be feasible to just do one round of V8_USE_UNSAFE_HANDLES
removal in a separate CL?
(That'll break all V8 users except blink & chromium though, but so will
this CL.)
https://chromiumcodereview.appspot.com/23401003/diff/1/include/v8.h
File include/v8.h (right):
https://chromiumcodereview.appspot.com/23401003/diff/1/include/v8.h#newcode484
include/v8.h:484: class NonCopyablePersistentTraits {
Neat :)
https://chromiumcodereview.appspot.com/23401003/diff/1/include/v8.h#newcode4708
include/v8.h:4708: static internal::Object**
CopyPersistent(internal::Object** handle);
This creates another legit Persistent for the same object, right? (And
creates a strong reference.) Can this func be named to reflect it
better? CreateNewGlobalReference or sth?
https://chromiumcodereview.appspot.com/23401003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
