LGTM, perhaps wait for a "LGTM" or "don't really care" from Michael.
https://codereview.chromium.org/23401003/diff/1/src/global-handles.h
File src/global-handles.h (right):
https://codereview.chromium.org/23401003/diff/1/src/global-handles.h#newcode148
src/global-handles.h:148: WeakCallback weak_callback,
On 2013/09/05 08:32:05, dcarney wrote:
On 2013/09/05 08:24:09, Sven Panne wrote:
> I'm a bit lost here: Why do we need a 2nd kind of callback (again)?
this handle removes direct access to the underlying persistent,
forcing the user
to dispose the handle directly themselves, which has always been an
issue
Ah, OK. So the revivable stuff is only there for a transitional phase,
right?
https://codereview.chromium.org/23401003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
