Rolled back the TC a few steps. Hope it's less puzzling now...
https://codereview.chromium.org/23589002/diff/1/test/mjsunit/array-push-non-smi-value.js
File test/mjsunit/array-push-non-smi-value.js (right):
https://codereview.chromium.org/23589002/diff/1/test/mjsunit/array-push-non-smi-value.js#newcode31
test/mjsunit/array-push-non-smi-value.js:31: (function() {
On 2013/08/27 13:58:36, Jakob wrote:
Why the outer closure?
Why indeed. Dropped.
https://codereview.chromium.org/23589002/diff/1/test/mjsunit/array-push-non-smi-value.js#newcode34
test/mjsunit/array-push-non-smi-value.js:34:
%OptimizeFunctionOnNextCall(a.push);
On 2013/08/27 13:58:36, Jakob wrote:
The patch only affects the stub. Why optimize the function?
I rolled back the TC a few steps (I suspect I tried to minimize it a bit
too aggressively...) I hope it makes more sense in that form. (I'm can't
claim to be entirely familiar with all details around stubs, so guidance
towards a better TC would be most appreciated.)
https://codereview.chromium.org/23589002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
