On 2013/08/27 16:16:12, fs wrote:
(I'm can't claim to be
entirely familiar with all details around stubs, so guidance towards a
better
TC
would be most appreciated.)
Well, you're fixing a bug, so the primary point of the test is that it fails
without your patch (proving that there is, in fact, a bug) and passes with
your
patch (proving that the patch fixes the bug). So the way to build such a
test is
to take the unpatched binary and write a test that fails with it; then if
necessary iterate on it until you like it (trim it down, clean it up,
whatever
-- or extend it to also cover related cases, depending on what the issue
is),
always making sure that it still fails as expected for the bug(s) you're
about
to fix.
Runtime function calls like %OptimizeFunctionOnNextCall (which are only
allowed
when the --allow-natives-syntax flag is present) are tools that help
recreate
specific circumstances in tests, if those are required to (reliably)
trigger a
bug. There's no reason to use them if you don't need them.
https://codereview.chromium.org/23589002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
