Reviewers: Jakob,
Description:
Temporarily skip escape analysis when compiling for OSR.
[email protected]
BUG=mjsunit/compiler/escape-analysis --stress-compaction
Please review this at https://codereview.chromium.org/23480028/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-escape-analysis.h
M src/hydrogen-escape-analysis.cc
Index: src/hydrogen-escape-analysis.cc
diff --git a/src/hydrogen-escape-analysis.cc
b/src/hydrogen-escape-analysis.cc
index
0e70bcdba5f67b2e184fa9f51fb360781717c408..00cfe278012265804fee661dfe33c971ea0d0c05
100644
--- a/src/hydrogen-escape-analysis.cc
+++ b/src/hydrogen-escape-analysis.cc
@@ -306,4 +306,13 @@ void HEscapeAnalysisPhase::PerformScalarReplacement() {
}
+void HEscapeAnalysisPhase::Run() {
+ // TODO(mstarzinger): We disable escape analysis with OSR for now,
because
+ // spill slots might be uninitialized. Needs investigation.
+ if (graph()->has_osr()) return;
+ CollectCapturedValues();
+ PerformScalarReplacement();
+}
+
+
} } // namespace v8::internal
Index: src/hydrogen-escape-analysis.h
diff --git a/src/hydrogen-escape-analysis.h b/src/hydrogen-escape-analysis.h
index
639f5a939609f38e43bf3cff82f75bc25cf7331c..311a653c972370dfab5261aa7f38fc2489d08e87
100644
--- a/src/hydrogen-escape-analysis.h
+++ b/src/hydrogen-escape-analysis.h
@@ -45,10 +45,7 @@ class HEscapeAnalysisPhase : public HPhase {
cumulative_values_(0),
block_states_(graph->blocks()->length(), zone()) { }
- void Run() {
- CollectCapturedValues();
- PerformScalarReplacement();
- }
+ void Run();
private:
void CollectCapturedValues();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
