https://codereview.chromium.org/23710014/diff/7001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/23710014/diff/7001/src/compiler.cc#newcode972
src/compiler.cc:972: ASSERT(osr_pc_offset != 0 ||
closure->IsMarkedForConcurrentRecompilation());
Not sure what you are trying to assert here.
https://codereview.chromium.org/23710014/diff/7001/src/compiler.cc#newcode994
src/compiler.cc:994: BailoutId osr_ast_id =
shared->code()->TranslatePcOffsetToAstId(
Are you calling this method in another place? Otherwise, you're passing
in a pointer to a loop_depth variable just to get it out for printing.
That seems weird. Pointers to local variables should be avoided.
https://codereview.chromium.org/23710014/diff/7001/src/compiler.cc#newcode1121
src/compiler.cc:1121: Handle<Code> unoptimized) {
Please put the mechanism for finding the osr_pc_offset back into the
runtime.
https://codereview.chromium.org/23710014/diff/7001/src/compiler.cc#newcode1154
src/compiler.cc:1154: BailoutId* ast_id) {
This should take the osr_pc_offset as a parameter.
https://codereview.chromium.org/23710014/diff/7001/src/compiler.cc#newcode1174
src/compiler.cc:1174: *ast_id =
unoptimized->TranslatePcOffsetToAstId(pc_offset, &loop_depth);
If you move this code back to the runtime, you don't need to pass
pointers to a BailoutId around.
https://codereview.chromium.org/23710014/diff/7001/src/compiler.cc#newcode1245
src/compiler.cc:1245: if (!function->IsOptimized()) {
You shouldn't check function->IsOptimized, but look at the result of the
code, which should be in the compilation info. Soon, OSR compilations
won't install the code into the function.
https://codereview.chromium.org/23710014/diff/7001/test/mjsunit/compiler/optimized-for-in.js
File test/mjsunit/compiler/optimized-for-in.js (right):
https://codereview.chromium.org/23710014/diff/7001/test/mjsunit/compiler/optimized-for-in.js#newcode29
test/mjsunit/compiler/optimized-for-in.js:29: // Flags:
--no-speculative-concurrent-osr
What's wrong here?
https://codereview.chromium.org/23710014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
