https://codereview.chromium.org/23710014/diff/18001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/23710014/diff/18001/src/compiler.cc#newcode973
src/compiler.cc:973: ASSERT(compiling_for_osr ||
closure->IsMarkedForConcurrentRecompilation());
On 2013/09/04 09:23:23, titzer wrote:
On second thought, yes, please take the assert out. It doesn't make
sense for
the compiler to dependent on the current state of a function. It
should just
generate code.
Done.
https://codereview.chromium.org/23710014/diff/18001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/23710014/diff/18001/src/flag-definitions.h#newcode334
src/flag-definitions.h:334: DEFINE_bool(speculative_concurrent_osr,
false,
On 2013/09/04 09:23:23, titzer wrote:
s/speculative_//g
It'd only be speculative if the compiler tried OSRing code before it's
executed.
Done.
https://codereview.chromium.org/23710014/diff/18001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/23710014/diff/18001/src/objects.cc#newcode10328
src/objects.cc:10328: BailoutId Code::TranslatePcOffsetToAstId(uint32_t
pc_offset) {
On 2013/09/04 09:23:23, titzer wrote:
ASSERT(kind() == FUNCTION)
Done. The BackEdgeTableIterator asserts the same, but I guess it doesn't
hurt.
https://codereview.chromium.org/23710014/diff/18001/src/optimizing-compiler-thread.cc
File src/optimizing-compiler-thread.cc (right):
https://codereview.chromium.org/23710014/diff/18001/src/optimizing-compiler-thread.cc#newcode112
src/optimizing-compiler-thread.cc:112:
ASSERT(FLAG_speculative_concurrent_osr);
On 2013/09/04 09:23:23, titzer wrote:
Don't assert flags.
Done.
https://codereview.chromium.org/23710014/diff/18001/src/optimizing-compiler-thread.cc#newcode157
src/optimizing-compiler-thread.cc:157:
ASSERT(FLAG_speculative_concurrent_osr);
On 2013/09/04 09:23:23, titzer wrote:
Here and several places below.
Done.
https://codereview.chromium.org/23710014/diff/18001/src/optimizing-compiler-thread.h
File src/optimizing-compiler-thread.h (right):
https://codereview.chromium.org/23710014/diff/18001/src/optimizing-compiler-thread.h#newcode56
src/optimizing-compiler-thread.h:56: osr_candidates_(2),
On 2013/09/04 09:23:23, titzer wrote:
Why not kReadyForOSRLimit?
Done.
https://codereview.chromium.org/23710014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
