Patch set 1 LGTM with comment.
Does your second comment refer to another patch set that you forgot to
upload?
https://codereview.chromium.org/23679007/diff/1/src/ia32/assembler-ia32.cc
File src/ia32/assembler-ia32.cc (right):
https://codereview.chromium.org/23679007/diff/1/src/ia32/assembler-ia32.cc#newcode1170
src/ia32/assembler-ia32.cc:1170: }
I think we may want to keep the "op.is_reg_only()" path (in addition to
the is_uint8(imm.x_) check).
https://codereview.chromium.org/23679007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
