On 2013/09/11 12:56:18, weiliang.lin2 wrote:
On 2013/09/11 11:04:06, Jakob wrote:
> On 2013/09/10 03:09:41, weiliang.lin2 wrote:
> >
https://codereview.chromium.org/23679007/diff/1/src/ia32/assembler-ia32.cc
> > File src/ia32/assembler-ia32.cc (right):
> >
> >
>
https://codereview.chromium.org/23679007/diff/1/src/ia32/assembler-ia32.cc#newcode1170
> > src/ia32/assembler-ia32.cc:1170: }
> > On 2013/09/09 19:16:51, Jakob wrote:
> > > I think we may want to keep the "op.is_reg_only()" path (in
addition to
the
> > > is_uint8(imm.x_) check).
> >
> > Actually op.is_reg_only() is handled in test_b functions.
>
> Yes, it is, but the old code has a reg_only path for non-int8
immediates,
which
> the new code does not. I haven't audited all call sites to see if we
actually
> make use of this, but since it's easy to support, it would be nice to
keep
> supporting it.
Yes, it is. reg_only path should be kept for non-int8 immediate. Thanks
for
remind.:)
Update to master
https://codereview.chromium.org/23679007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
