PTAL
https://codereview.chromium.org/23548024/diff/4001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/23548024/diff/4001/src/bootstrapper.cc#newcode1320
src/bootstrapper.cc:1320: Handle<ByteArray>
random_seed(factory->NewByteArray(kRandomStateSize));
On 2013/09/09 17:11:25, Michael Starzinger wrote:
nit: Use assignment instead of copy constructor.
Done.
https://codereview.chromium.org/23548024/diff/4001/src/bootstrapper.cc#newcode2410
src/bootstrapper.cc:2410: // using the per-isolate random number
generator.
On 2013/09/09 17:11:25, Michael Starzinger wrote:
It seems "ConfigureGlobalObjects" is a bad name for this
initialization, can we
either move it into Genesis::Genesis directly (i.e. after experimental
natives
are initialized)?
Just this piece of code, or the whole ConfigureGlobalObjects?
https://codereview.chromium.org/23548024/diff/4001/src/flags.h
File src/flags.h (right):
https://codereview.chromium.org/23548024/diff/4001/src/flags.h#newcode31
src/flags.h:31: #include "atomicops.h"
On 2013/09/09 17:11:25, Michael Starzinger wrote:
I am not sure why this header needs the atomicops.h include. Is it
just to break
some weird circular dependency?
Because flag-definitions.h uses AtomicWord.
https://codereview.chromium.org/23548024/diff/4001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/23548024/diff/4001/src/heap.cc#newcode6933
src/heap.cc:6933: isolate()->random_number_generator()->NextInt() &
On 2013/09/09 17:11:25, Michael Starzinger wrote:
nit: Indentation is off.
Done.
https://codereview.chromium.org/23548024/diff/4001/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/23548024/diff/4001/src/isolate.h#newcode1129
src/isolate.h:1129: inline RandomNumberGenerator*
random_number_generator() V8_WARN_UNUSED_RESULT;
On 2013/09/09 17:11:25, Michael Starzinger wrote:
I don't think it is vitally important that the result of this simple
getter is
actually used. The world is not going to end if someone calls the
getter without
using the result. Can we please keep this line readable and drop the
V8_WARN_UNUSED_RESULT? Unless I am missing a whole class of bugs that
will
actually be caught by this warning.
Done.
https://codereview.chromium.org/23548024/diff/4001/src/platform/time.h
File src/platform/time.h (right):
https://codereview.chromium.org/23548024/diff/4001/src/platform/time.h#newcode227
src/platform/time.h:227: static Time FromInternalValue(int64_t value)
V8_WARN_UNUSED_RESULT {
On 2013/09/09 17:11:25, Michael Starzinger wrote:
Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.
Done.
https://codereview.chromium.org/23548024/diff/4001/src/platform/time.h#newcode230
src/platform/time.h:230: int64_t ToInternalValue() const
V8_WARN_UNUSED_RESULT {
On 2013/09/09 17:11:25, Michael Starzinger wrote:
Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.
Done.
https://codereview.chromium.org/23548024/diff/4001/src/platform/time.h#newcode343
src/platform/time.h:343: static TimeTicks FromInternalValue(int64_t
value) V8_WARN_UNUSED_RESULT {
On 2013/09/09 17:11:25, Michael Starzinger wrote:
Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.
Done.
https://codereview.chromium.org/23548024/diff/4001/src/platform/time.h#newcode346
src/platform/time.h:346: int64_t ToInternalValue() const
V8_WARN_UNUSED_RESULT {
On 2013/09/09 17:11:25, Michael Starzinger wrote:
Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.
Done.
https://codereview.chromium.org/23548024/diff/4001/src/v8.cc
File src/v8.cc (right):
https://codereview.chromium.org/23548024/diff/4001/src/v8.cc#newcode118
src/v8.cc:118: // When we get, the RNG must have been initialized, see
On 2013/09/09 17:11:25, Michael Starzinger wrote:
nit: s/get/get here/
Done.
https://codereview.chromium.org/23548024/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
