https://codereview.chromium.org/23548024/diff/4001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/23548024/diff/4001/src/bootstrapper.cc#newcode2410
src/bootstrapper.cc:2410: // using the per-isolate random number
generator.
On 2013/09/10 08:43:31, Michael Starzinger wrote:
On 2013/09/10 06:08:07, Benedikt Meurer wrote:
> On 2013/09/09 17:11:25, Michael Starzinger wrote:
> > It seems "ConfigureGlobalObjects" is a bad name for this
initialization, can
> we
> > either move it into Genesis::Genesis directly (i.e. after
experimental
natives
> > are initialized)?
>
> Just this piece of code, or the whole ConfigureGlobalObjects?
Just this new piece of initialization.
Done.
https://codereview.chromium.org/23548024/diff/15001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/23548024/diff/15001/src/api.cc#newcode67
src/api.cc:67: #include "utils/random-number-generator.h"
On 2013/09/10 08:43:31, Michael Starzinger wrote:
nit: Can we alpha-sort the includes?
Done.
https://codereview.chromium.org/23548024/diff/15001/src/utils/random-number-generator.h
File src/utils/random-number-generator.h (right):
https://codereview.chromium.org/23548024/diff/15001/src/utils/random-number-generator.h#newcode62
src/utils/random-number-generator.h:62: V8_INLINE(int NextInt())
V8_WARN_UNUSED_RESULT {
On 2013/09/10 08:43:31, Michael Starzinger wrote:
nit: Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.
As per offline discussion: This is a valid use.
https://codereview.chromium.org/23548024/diff/15001/src/utils/random-number-generator.h#newcode72
src/utils/random-number-generator.h:72: int NextInt(int max)
V8_WARN_UNUSED_RESULT;
On 2013/09/10 08:43:31, Michael Starzinger wrote:
nit: Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.
As per offline discussion: This is a valid use.
https://codereview.chromium.org/23548024/diff/15001/src/utils/random-number-generator.h#newcode79
src/utils/random-number-generator.h:79: V8_INLINE(bool NextBool())
V8_WARN_UNUSED_RESULT {
On 2013/09/10 08:43:31, Michael Starzinger wrote:
nit: Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.
As per offline discussion: This is a valid use.
https://codereview.chromium.org/23548024/diff/15001/src/utils/random-number-generator.h#newcode88
src/utils/random-number-generator.h:88: double NextDouble()
V8_WARN_UNUSED_RESULT;
On 2013/09/10 08:43:31, Michael Starzinger wrote:
nit: Ceterum censeo V8_WARN_UNUSED_RESULT esse delendam.
As per offline discussion: This is a valid use.
https://codereview.chromium.org/23548024/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
