On 2013/09/10 11:00:46, titzer wrote:
https://codereview.chromium.org/23842004/diff/7010/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/23842004/diff/7010/src/compiler.cc#newcode1145
src/compiler.cc:1145: Deoptimizer::RevertInterruptCode(isolate,
*unoptimized);
Please move this reversion of the interrupt code back into the runtime.
The
compiler should not be responsible for doing so.
https://codereview.chromium.org/23842004/diff/7010/src/compiler.cc#newcode1152
src/compiler.cc:1152: if (IsSuitableForOnStackReplacement(isolate,
function,
unoptimized)) {
And this as well. The compiler should just compile code, not enforce
policy
about when/where.
Those suggested refactorings are not scope of this CL, so I would like to
move
that to another one.
Moving Deoptimizer::RevertInterruptCode and IsSuitableForOnStackReplacement
from
CompileForOnStackReplacement to runtime is simple, but not that simple for
CompileForConcurrentOSR, since we call both functions depending on which
stage
of concurrent OSR we are at. I would split CompileForConcurrentOSR into
several
functions, one for each stage we are at, and call
Deoptimizer::RevertInterruptCode and IsSuitableForOnStackReplacement where
appropriate.
https://codereview.chromium.org/23842004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
