Addressed comment and refactored a bunch of stuff. Please take a look.
https://codereview.chromium.org/23842004/diff/19001/src/runtime-profiler.cc
File src/runtime-profiler.cc (right):
https://codereview.chromium.org/23842004/diff/19001/src/runtime-profiler.cc#newcode150
src/runtime-profiler.cc:150: return;
This is not actually a change in heuristic. We used to return
Handle<Code>::null() in Compiler::CompileForConcurrentOSR when
recompilation didn't finish. Runtime_CompileForOnStackReplacement would
then overwrite the builtin marker by shared code. Since that's gone now,
I just decided to simulate this by not marking a function for regular
recompilation if it's already queued for OSR.
This won't be any issue once OSR becomes one-shot, since we don't
install the optimized code onto the function in that case.
https://codereview.chromium.org/23842004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
