On 2013/09/11 15:27:52, Toon Verwaest wrote:
https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h#newcode2412
src/hydrogen.h:2412: bool found = false;
Hence the version I attached in my previous comment ;)
In the end I went with the Toon special.
On 2013/09/11 15:01:49, rossberg wrote:
> On 2013/09/11 14:24:11, Toon Verwaest wrote:
> > This version double-checks every entry though; since you don't
increment
to
> the
> > next value if sought == that->array[j].
> >
> > On 2013/09/11 10:34:07, rossberg wrote:
> > > The rest of this for-loop could be simplified to:
> > >
> > > while (j < that->size_ && sought != that->array_[j]) j++;
> > > if (j == that->size_) return false;
>
> Good catch. Tweaking that is left as an exercise. :)
https://codereview.chromium.org/23609020/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
