On 2013/09/11 16:52:40, titzer wrote:
On 2013/09/11 10:34:07, rossberg wrote:
> https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h
> File src/hydrogen.h (right):
>
>
https://codereview.chromium.org/23609020/diff/1/src/hydrogen.h#newcode2309
> src/hydrogen.h:2309: class HUnique V8_FINAL {
> I think this should live somewhere else (e.g. handles.h or perhaps its
own
> file), and be named Unique, since it isn't really specific to Hydrogen.
Btw, as per discussion with Toon, I've moved this to hydrogen-unique.h.
Thanks. But please also remove the hydrogen and H from the names. This
abstraction is in no way specific to Hydrogen, and we gonna use it in other
places soon (e.g. zonified types).
https://codereview.chromium.org/23609020/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
