On 2013/09/11 13:37:02, Yang wrote:
On 2013/09/11 11:34:14, Jakob wrote:
> Redirecting to Yang.

We use cvtsi2sd in a couple of other places as well. Would it make sense to do
that elsewhere as well? Or even bundle xorps and cvtsi2sd into a
MacroAssembler
method and use that everywhere?

Sound good suggestion. But I need to measure more performance test to see
whether using it everywhere has negative impact.

Actually, I found this issue when I tune this fix
(https://codereview.chromium.org/23717039/). I found that when disable
left/right switch has big negative performance impact on audio-oscillator case. From ll-prof, there is quite big latency for cvtsi2sd instruction (emitted by
Integer32ToInt).

So I tried to use the common way to break its false dependency.

@Sven
Please see http://www.agner.org/optimize/optimizing_assembly.pdf Section 9.5
Break dependency chains

https://codereview.chromium.org/23654026/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to