I can confirm the performance improvements. This is great!
Could you add a comment on the background of this change? From what I
gathered,
this has something to do with register renaming internal to the CPU?
Also, could you rebase before I land this change? Some of the calls of
cvtsi2sd
have been removed yesterday.
https://codereview.chromium.org/23654026/diff/7001/src/ia32/macro-assembler-ia32.h
File src/ia32/macro-assembler-ia32.h (right):
https://codereview.chromium.org/23654026/diff/7001/src/ia32/macro-assembler-ia32.h#newcode369
src/ia32/macro-assembler-ia32.h:369: // Use xorps to clear out the
destination register before cvtsi2sd
Could you add a comment on why we do this? I mean, it's not entirely
obvious why we need to clear out the destination register, so it would
be great if somebody working on this code in the future can figure out
what the background of this change is.
https://codereview.chromium.org/23654026/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
