Updates:
Owner: [email protected]
Cc: [email protected]
Comment #2 on issue 2881 by [email protected]: Code generator still
generates constants even if the inlined into instruction
http://code.google.com/p/v8/issues/detail?id=2881
Without the OSR check, the standard constants are never "executed" in the
first block of a graph since we enter in the middle of the graph, leaving
registers and stack slots that are supposed to contain them initialized
with garbage --> crash. The "right" fix is being worked on by titzer@ to
make all compiled code, even OSRed code, has a single entry point that
guarantees that the standard constants are executed and spilled if
necessary.
That being said, the handling of standard constants here is overly
conservative. It should actually be:
if (block()->graph()->has_osr() &&
block()->graph()->IsStandardConstant(this)) {
return true;
}
Making sure the handling of non-standard constants in OSR code is the same
as in non-OSR code.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
