On 2013/09/16 11:18:09, alph wrote:
https://codereview.chromium.org/24174002/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):


https://codereview.chromium.org/24174002/diff/1/src/heap-snapshot-generator.cc#newcode2696
src/heap-snapshot-generator.cc:2696: Vector<HashMap::Entry*> sorted_strings =
A vector of strings instead of Entries should be a bit faster.

done



https://codereview.chromium.org/24174002/diff/1/src/heap-snapshot-generator.cc#newcode2701
src/heap-snapshot-generator.cc:2701:
sorted_strings[reinterpret_cast<uintptr_t>(entry->value)] = entry;
nit: parentheses

done

https://codereview.chromium.org/24174002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to