I suppose that the value is set by GetStringId, which assigns it by a
growing
index, making it unrelated to the string content. In that case, the sort
order
is arbitrary, even if reproducible. Why do we need it to be sorted to begin
with?
https://codereview.chromium.org/24174002/diff/7001/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/24174002/diff/7001/src/heap-snapshot-generator.cc#newcode2697
src/heap-snapshot-generator.cc:2697: Vector<const unsigned
char*>::New(strings_.occupancy() + 1);
We don't seem to call Dispose on the Vector anywhere. Leak?
https://codereview.chromium.org/24174002/diff/7001/src/heap-snapshot-generator.cc#newcode2700
src/heap-snapshot-generator.cc:2700: entry = strings_.Next(entry)) {
indentation is a bit off.
https://codereview.chromium.org/24174002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
