On 2013/09/17 12:37:34, Sven Panne wrote:
LGTM with a nit.
https://codereview.chromium.org/23523060/diff/6001/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/23523060/diff/6001/src/assembler.cc#newcode218
src/assembler.cc:218: CpuFeatures::found_by_runtime_probing_only_ |= mask;
Huh? "... &= ~mask" seems to be more straightforward. In any case,
CpuFeatures
should really use EnumSet instead of this bit-fiddling, but that's
something
for
the future.
omg, we discovered bit-not :/
https://codereview.chromium.org/23523060/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
