Before we land this, I'd like to see where and why we will need this change.
https://codereview.chromium.org/23523060/diff/1/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (right):
https://codereview.chromium.org/23523060/diff/1/src/ia32/assembler-ia32.h#newcode538
src/ia32/assembler-ia32.h:538: if ((force_feature_ &
(static_cast<uint64_t>(1) << f)) != 0) return true;
Lift out
static_cast<uint64_t>(1) << f
into a private helper now that it's all over the place.
https://codereview.chromium.org/23523060/diff/1/src/ia32/assembler-ia32.h#newcode558
src/ia32/assembler-ia32.h:558: static void ForceFeature(CpuFeature f) {
I am not sure about the future use cases, perhaps some scoped form might
be more appropriate.
https://codereview.chromium.org/23523060/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
