+ Ported to arm and x64
https://codereview.chromium.org/23710070/diff/13001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/23710070/diff/13001/src/hydrogen-instructions.cc#newcode2847
src/hydrogen-instructions.cc:2847: if (CheckFlag(kCanOverflow))
stream->Add(" !");
On 2013/09/19 16:24:27, titzer wrote:
maybe [can-overflow] instead of a cryptic bang.
Well this is kind of our canonical format, binary ops e.g. use the same.
If we want to change this we should do it everywhere...
https://codereview.chromium.org/23710070/diff/13001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/23710070/diff/13001/src/hydrogen.cc#newcode2633
src/hydrogen.cc:2633: // We can ignore ObservableSideEffects here since
CreateJoin will add
On 2013/09/19 16:24:27, titzer wrote:
I find this comment confusing and would rather just leave it out.
Done.
https://codereview.chromium.org/23710070/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
