On 2013/09/20 06:36:30, Sven Panne wrote:
https://codereview.chromium.org/23710070/diff/13001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/23710070/diff/13001/src/hydrogen-instructions.cc#newcode2847
src/hydrogen-instructions.cc:2847: if (CheckFlag(kCanOverflow))
stream->Add("
!");
On 2013/09/19 16:38:00, oliv wrote:
> On 2013/09/19 16:24:27, titzer wrote:
> > maybe [can-overflow] instead of a cryptic bang.
>
> Well this is kind of our canonical format, binary ops e.g. use the
same. If
we
> want to change this we should do it everywhere...
Do *not* change this, even if it is cryptic, it might be the case that
external
programs depend on this, perhaps some of Slava's stuff (don't know
though).
And what we should actually do is to factor out printing our ugly zoo of
ad-hoc
flags to HValue.
LGTM
For the record, I think that we should move Crankshaft toward having
smaller,
independent instructions, and get rid of all of our *AndBranch variants. I'm
glad this CL normalizes this case; I think I noticed it was weird before.
https://codereview.chromium.org/23710070/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
