Revision: 16852
Author: [email protected]
Date: Fri Sep 20 08:49:33 2013 UTC
Log: Prevent test-log.cc from creating log files.
[email protected]
TEST=cctest/test-log/EquivalenceOfLoggingAndTraversal
Review URL: https://codereview.chromium.org/23526073
http://code.google.com/p/v8/source/detail?r=16852
Modified:
/branches/bleeding_edge/src/flag-definitions.h
/branches/bleeding_edge/src/log.cc
/branches/bleeding_edge/test/cctest/test-log.cc
=======================================
--- /branches/bleeding_edge/src/flag-definitions.h Tue Sep 17 15:32:21 2013
UTC
+++ /branches/bleeding_edge/src/flag-definitions.h Fri Sep 20 08:49:33 2013
UTC
@@ -771,6 +771,7 @@
"Used with --prof, turns on browser-compatible mode for
profiling.")
DEFINE_bool(log_regexp, false, "Log regular expression execution.")
DEFINE_string(logfile, "v8.log", "Specify the name of the log file.")
+DEFINE_bool(logfile_per_isolate, true, "Separate log files for each
isolate.")
DEFINE_bool(ll_prof, false, "Enable low-level linux profiler.")
DEFINE_string(gc_fake_mmap, "/tmp/__v8_gc__",
"Specify the name of the file for fake gc mmap used in
ll_prof")
=======================================
--- /branches/bleeding_edge/src/log.cc Wed Sep 11 10:59:39 2013 UTC
+++ /branches/bleeding_edge/src/log.cc Fri Sep 20 08:49:33 2013 UTC
@@ -1765,15 +1765,14 @@
static void AddIsolateIdIfNeeded(Isolate* isolate, StringStream* stream) {
- if (isolate->IsDefaultIsolate()) return;
+ if (isolate->IsDefaultIsolate() || !FLAG_logfile_per_isolate) return;
stream->Add("isolate-%p-", isolate);
}
static SmartArrayPointer<const char> PrepareLogFileName(
Isolate* isolate, const char* file_name) {
- if (strchr(file_name, '%') != NULL ||
- !isolate->IsDefaultIsolate()) {
+ if (strchr(file_name, '%') != NULL || !isolate->IsDefaultIsolate()) {
// If there's a '%' in the log file name we have to expand
// placeholders.
HeapStringAllocator allocator;
=======================================
--- /branches/bleeding_edge/test/cctest/test-log.cc Thu Sep 19 15:06:20
2013 UTC
+++ /branches/bleeding_edge/test/cctest/test-log.cc Fri Sep 20 08:49:33
2013 UTC
@@ -91,6 +91,7 @@
i::FLAG_log = true;
i::FLAG_prof = true;
i::FLAG_logfile = i::Log::kLogToTemporaryFile;
+ i::FLAG_logfile_per_isolate = false;
return false;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
