[v8-dev] Skip intl tests from test262 when intl support is disabled. (issue 23792008)

Fri, 20 Sep 2013 01:52:48 -0700 

Reviewers: Michael Starzinger, jochen,

Message:
PTAL

Description:
Skip intl tests from test262 when intl support is disabled.

Skips the whole intl directory if intl support is disabled through the test
driver.
One test outside the intl directory is skipped separately. It will be handled in 
an extra CL.

Please review this at https://codereview.chromium.org/23792008/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+13, -5 lines):
  M test/test262/test262.status
  M test/test262/testcfg.py
  M tools/run-deopt-fuzzer.py
  M tools/run-tests.py
  M tools/testrunner/objects/context.py


Index: test/test262/test262.status
diff --git a/test/test262/test262.status b/test/test262/test262.status
index 1fd4c3c5d82df6a69e5cfc5185c45981807dd281..02dfc1ef5db7a5f37d67901b1e0ce0096a076925 100644 
--- a/test/test262/test262.status
+++ b/test/test262/test262.status
@@ -36,6 +36,9 @@ def FAIL_OK = FAIL, OKAY
 # V8 Bug: http://code.google.com/p/v8/issues/detail?id=691
 11.2.3-3_3: FAIL

+# TODO(jochen): Needs to be skipped only in noi18n mode.
+15.5.4.9_CE: SKIP
+
 ######################## NEEDS INVESTIGATION ###########################
# These test failures are specific to the intl402 suite and need investigation 
Index: test/test262/testcfg.py
diff --git a/test/test262/testcfg.py b/test/test262/testcfg.py
index f723eb01c382bb5274eb75fbb9e40920639a3157..89f729d9a34a533d8c58e0d1bca40d9e0ad0bf19 100644 
--- a/test/test262/testcfg.py
+++ b/test/test262/testcfg.py
@@ -59,6 +59,8 @@ class Test262TestSuite(testsuite.TestSuite):
     for dirname, dirs, files in os.walk(self.testroot):
       for dotted in [x for x in dirs if x.startswith(".")]:
         dirs.remove(dotted)
+      if context.noi18n and "intl402" in dirs:
+        dirs.remove("intl402")
       dirs.sort()
       files.sort()
       for filename in files:
Index: tools/run-deopt-fuzzer.py
diff --git a/tools/run-deopt-fuzzer.py b/tools/run-deopt-fuzzer.py
index f8cc93748abab1b54610ac0e0d455efeef87f2c4..bbe0dc7bd7d98f313ab61f99365506eff3889e4c 100755 
--- a/tools/run-deopt-fuzzer.py
+++ b/tools/run-deopt-fuzzer.py
@@ -358,7 +358,8 @@ def Execute(arch, mode, args, options, suites, workspace): 
                         mode_flags, options.verbose,
                         timeout, options.isolates,
                         options.command_prefix,
-                        options.extra_flags)
+                        options.extra_flags,
+                        False)

   # Find available test suites and read test cases from them.
   variables = {
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index d023cf1fbaaacab83806a0bdf2b8177e48fe9ef1..65bc96542545cdd9f97195c11b27958a1c371ca8 100755 
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -307,7 +307,8 @@ def Execute(arch, mode, args, options, suites, workspace): 
                         mode_flags, options.verbose,
                         timeout, options.isolates,
                         options.command_prefix,
-                        options.extra_flags)
+                        options.extra_flags,
+                        options.no_i18n)

   # Find available test suites and read test cases from them.
   variables = {
Index: tools/testrunner/objects/context.py
diff --git a/tools/testrunner/objects/context.py b/tools/testrunner/objects/context.py index 3ea215a708d00c319ea4f691f0dad48cd0008803..1f525b76b3114793b3548f2c740e7427805be0fc 100644 
--- a/tools/testrunner/objects/context.py
+++ b/tools/testrunner/objects/context.py
@@ -28,7 +28,7 @@

 class Context():
   def __init__(self, arch, mode, shell_dir, mode_flags, verbose, timeout,
-               isolates, command_prefix, extra_flags):
+               isolates, command_prefix, extra_flags, noi18n):
     self.arch = arch
     self.mode = mode
     self.shell_dir = shell_dir
@@ -38,13 +38,14 @@ class Context():
     self.isolates = isolates
     self.command_prefix = command_prefix
     self.extra_flags = extra_flags
+    self.noi18n = noi18n

   def Pack(self):
return [self.arch, self.mode, self.mode_flags, self.timeout, self.isolates, 
-            self.command_prefix, self.extra_flags]
+            self.command_prefix, self.extra_flags, self.noi18n]

   @staticmethod
   def Unpack(packed):
     # For the order of the fields, refer to Pack() above.
     return Context(packed[0], packed[1], None, packed[2], False,
-                   packed[3], packed[4], packed[5], packed[6])
+                   packed[3], packed[4], packed[5], packed[6], packed[7])


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to