Reviewers: ulan, Benedikt Meurer,
Message:
On 2013/09/20 10:31:20, Benedikt Meurer wrote:
https://codereview.chromium.org/23447035/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/23447035/diff/1/src/arm/macro-assembler-arm.cc#newcode3224
src/arm/macro-assembler-arm.cc:3224: b(ne, &align_loop_1);
Shouldn't this be an unconditional branch to align_loop_1? Because length
cannot
become zero w/o src being properly aligned, right?
You are right, it would be better use unconditional branch since loop
counter is
grater than 4.
I am testing the changes now.
Description:
Fixed a bug in CopyBytes() and new test cases for ARM macro assembler
TEST=cctest/test-macro-assembler-arm
Please review this at https://codereview.chromium.org/23447035/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+143, -7 lines):
M src/arm/macro-assembler-arm.cc
M test/cctest/cctest.gyp
A test/cctest/test-macro-assembler-arm.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
