On 2013/09/20 10:47:12, Bangfu wrote:
On 2013/09/20 10:31:20, Benedikt Meurer wrote:
>
https://codereview.chromium.org/23447035/diff/1/src/arm/macro-assembler-arm.cc
> File src/arm/macro-assembler-arm.cc (right):
>
>
https://codereview.chromium.org/23447035/diff/1/src/arm/macro-assembler-arm.cc#newcode3224
> src/arm/macro-assembler-arm.cc:3224: b(ne, &align_loop_1);
> Shouldn't this be an unconditional branch to align_loop_1? Because
length
cannot
> become zero w/o src being properly aligned, right?
You are right, it would be better use unconditional branch since loop
counter
is
grater than 4.
I am testing the changes now.
Done.
https://codereview.chromium.org/23447035/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
